RE: apply worker misses closing partition leaves

On Monday, August 24, 2026 8:36 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Mon, 24 Aug 2026 at 22:33, Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com>
> wrote:
> > The fix looks good to me. I just noticed one nit in the test:
> >
> > + ok(!$node->log_contains(qr/resource was not closed/),
> > + 'unclosed resources on ' . $node->name);
> >
> > I think the test message should be: "no unclosed resources on".
>
> Sorry, I must be missing something here. You want the message that
> complains when there *is* a resource leak WARNING say "no unclosed
> resources on $server"?
>
> Maybe if that message is confusing, then it might be better to write "resource
> leak detected on $server". Is that any better?

IIUC, the test is intended to ensure there is no resource leak.

ok(!$node->log_contains(qr/resource was not closed/),

Since the test verifies the absence of the warning message, the test message
should reflect that positive outcome(it's output when there is no such
warning), right ?

BTW, the v16 patch's message looks correct ("no unclosed resources on ")

Best Regards,
Zhijie Hou