Re: Fix incorrect comments in tuplesort.c

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix incorrect comments in tuplesort.c
Date: 2025-12-09 23:02:21
Message-ID: CAApHDvpud80+5j0aRHCLcMV-C2zBmGHLyWNu6W+4a33SZVZLww@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 8 Dec 2025 at 15:08, cca5507 <cca5507(at)qq(dot)com> wrote:
> > Using "However" here indicates some exception to what's just been
> > said, but there is no longer an exception. To write about what the
> > 1024 is for, we might need to reverse engineer what that's for. I
> > assume it's something like "Clamp at 1024 elements to avoid excessive
> > reallocs of the array". Or perhaps that without the " of the array"
> > part.
>
> Agreed. I prefer without the " of the array" part.

OK. Done like that. Thanks.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2025-12-09 23:05:42 Re: [Proposal] Adding callback support for custom statistics kinds
Previous Message Michael Paquier 2025-12-09 23:00:29 Re: Consistently use palloc_object() and palloc_array()