| From: | cca5507 <cca5507(at)qq(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, David G(dot) Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix incorrect comments in tuplesort.c |
| Date: | 2025-12-08 02:07:53 |
| Message-ID: | tencent_ADDD45A84EA1446D47CA8B4C2D1ED881A606@qq.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Using "However" here indicates some exception to what's just been
> said, but there is no longer an exception. To write about what the
> 1024 is for, we might need to reverse engineer what that's for. I
> assume it's something like "Clamp at 1024 elements to avoid excessive
> reallocs of the array". Or perhaps that without the " of the array"
> part.
Agreed. I prefer without the " of the array" part.
--
Regards,
ChangAo Chen
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2025-12-08 02:12:35 | [PATCH] test_aio: Skip io_uring tests when kernel disables it |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-12-08 02:04:27 | Fix LOCK_TIMEOUT handling in slotsync worker |