| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tomas(at)vondra(dot)me |
| Subject: | Re: Fix wrong filename in header comment of gin_tuple.h |
| Date: | 2025-09-23 00:14:01 |
| Message-ID: | CAApHDvpCd_YkeBs2U1q1bTv2PEy9j4+FrEc_qZXLhNR2s8pS2Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 23 Sept 2025 at 10:21, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> My script just scan all .c and .h files and extract one-line filename and file path from header comments. If they don’t equal to either pure filename or file path relative to repo root, then capture it. And rowsecurity.c was the only capture, so I thought the filename part (“rewrite/rowsecurity.c) was a problem. When I made the fix, I added “IDENTIFICATION” because I saw a lot of other files having it, but my script didn’t check “IDENTIFICATION”.
Thanks for explaining that.
> I don’t insist to push this patch if you don’t consider the filename part is a problem.
I don't, personally. But will defer to anyone who thinks it's more of
an issue than I do.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-09-23 00:45:18 | Re: Trivial fix for comment of function table_tuple_lock |
| Previous Message | David Rowley | 2025-09-23 00:02:42 | Re: Fix overflow of nbatch |