Re: Trivial fix for comment of function table_tuple_lock

On Tue, Sep 23, 2025 at 7:44 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
> On Mon, Sep 22, 2025 at 11:41 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>>
>>
>> I noticed a few other issues. Wouldn’t it be better to fix these together?
>>
>> * changingPart is listed as an output parameter for table_tuple_delete(),
>> but it looks like an input.
>
>
> Fixed. changingPart is of type bool, it cannot pass out anything.
>
>>
>> * slot is listed as an input parameter for table_tuple_update(), but it seems
>> to be an output.
>
>
> Fixed. Yes, slot will get some field assigned inside the function.
>
>>
>> * The comment for update_indexes in table_tuple_update() is mis-indented.
>
>
> Fixed. Other parameters use a tab in front, while update_indexes used two white-space in front.
>
>>
>> * Not an issue, but it might be clearer to add a blank line between the input
>> and output parameter comments in table_tuple_delete() and
>> table_tuple_update().
>>
>
> Added new lines.

Thanks for updating the patch! LGTM.
Barring any objections, I'll commit it.

I noticed the commit message in the patch lists you as "Author: Chao
Li <lic(at)highgo(dot)com>",
but in this discussion you've been using "li(dot)evan(dot)chao(at)gmail(dot)com",
which also seems to be the address used in past commit logs for you.
Which email address would you like me to use in the commit log?

Regards,

--
Fujii Masao