| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Vaibhav Jain <jainva(at)google(dot)com>, pgsql-hackers(at)postgresql(dot)org, Madhukar <madhukarprasad(at)google(dot)com>, Sangeetha Seshadri <sangsesh(at)google(dot)com> |
| Subject: | Re: Fix overflow of nbatch |
| Date: | 2025-09-23 00:02:42 |
| Message-ID: | CAApHDvr5UCPBtr83LJa2XGrVMxyhH52V=TX3D7eU4bEx8YHD1A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 23 Sept 2025 at 09:31, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> On 9/22/25 22:45, David Rowley wrote:
> > I think a1b4f289b mistakenly thought that there'd be size_t arithmetic
> > in the following two lines because the final result is a size_t:
> >
> > size_t current_space = hash_table_bytes + (2 * nbatch * BLCKSZ);
> > size_t new_space = hash_table_bytes * 2 + (nbatch * BLCKSZ);
> >
>
> Yeah, I failed to notice this part of the formula can overflow.
Ok cool. We're just in the freeze for 18.0 at the moment. Once that's
over, should I take care of this, or do you want to?
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-09-23 00:14:01 | Re: Fix wrong filename in header comment of gin_tuple.h |
| Previous Message | David Rowley | 2025-09-22 23:35:54 | Re: Fix overflow of nbatch |