| From: | James Coleman <jtc331(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
| Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Date: | 2020-04-07 02:12:18 |
| Message-ID: | CAAaqYe8rav8Un4K_NxXrH8JP-nnvBbppKPjTJjJKfLndsvWKbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 6, 2020 at 10:09 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> James Coleman <jtc331(at)gmail(dot)com> writes:
> > On Mon, Apr 6, 2020 at 9:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> I think the correct fix is to change the enum declaration.
>
> > Hmm. I don't actually really like that, because it means the value
> > here isn't actually semantically correct. That is, the sort type is
> > not "in progress"; it's "we never started a sort at all".
>
> Well, yeah, but that pre-dated this patch, and right now is no
> time to improve it; we can debate such fine points at more leisure
> once the buildfarm isn't broken.
Fair enough. Unsure if Tomas is still online to comment and/or push,
but reverting SORT_TYPE_STILL_IN_PROGRESS back to 0 works for me as an
initial fix.
> Obviously the comment needs fixed...
The one in show_short_info?
I can work on that (and the other proposed cleanup above) with Tomas
tomorrow or later.
James
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-04-07 02:12:49 | Re: WAL usage calculation patch |
| Previous Message | Tom Lane | 2020-04-07 02:09:09 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |