| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kirill Bychik <kirill(dot)bychik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: WAL usage calculation patch |
| Date: | 2020-04-07 02:12:49 |
| Message-ID: | CAA4eK1+Gwy=-teh7dGYY03qsYVAekHfokie8LWSwGXOGp3YOMw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 6, 2020 at 10:01 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> On Mon, Apr 06, 2020 at 05:01:30PM +0200, Peter Eisentraut wrote:
> > I noticed in some of the screenshots that were tweeted that for example in
> >
> > WAL: records=1 bytes=56
> >
> > there are two spaces between pieces of data. This doesn't match the rest of
> > the EXPLAIN output. Can that be adjusted?
>
> We talked about that here:
> https://www.postgresql.org/message-id/20200402054120.GC14618%40telsasoft.com
>
Yeah. Just to brief here, the main reason was that one of the fields
(full page writes) already had a single space and then we had prior
cases as mentioned in Justin's email [1] where we use two spaces which
lead us to decide using two spaces in this case.
Now, we can change back to one space as suggested by you but I am not
sure if that is an improvement over what we have done. Let me know if
you think otherwise.
[1] - https://www.postgresql.org/message-id/20200402054120.GC14618%40telsasoft.com
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-07 02:19:41 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
| Previous Message | James Coleman | 2020-04-07 02:12:18 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |