| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Assert("vacrel->eager_scan_remaining_successes > 0") |
| Date: | 2025-05-22 20:19:41 |
| Message-ID: | CAAKRu_aBkNpb_4n6Rm=J5igVRTmzO09EFpUaaq3LogHSbkckNA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Agreed. I've updated the patch. Does this address your comments?
Yep. LGTM.
I'd probably just remove the parenthetical remark about 20% from the
commit message since that only applies to the success cap and
referencing both the success and failure caps will make the sentence
very long.
from the commit message:
pages (beyond 20% of the total number of all-visible but not
all-frozen pages), this does not pose a practical concern as the
Thanks again for writing the patch!
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2025-05-22 20:19:53 | Re: [Util] Warn and Remove Invalid GUCs |
| Previous Message | Peter Eisentraut | 2025-05-22 20:17:30 | Re: Log connection establishment timings |