Re: [Util] Warn and Remove Invalid GUCs

From: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>, Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, mujeebskdev <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>
Subject: Re: [Util] Warn and Remove Invalid GUCs
Date: 2025-05-22 20:19:53
Message-ID: CAKAnmmJ5ofEX6u82m42iRm__Q0wqcCu1TPC9zF_shwWPNpp70A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 22, 2025 at 12:45 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> > "lpgsql.bogus = 1" .
>
> [ shrug... ] How do you know that's a bogus prefix? It could perfectly
> well be a fully valid setting for an extension that
> the installation doesn't choose to preload.
>

Well, we do have ways to view all *potential* extensions. I find myself
more sympathetic to the OP than the others here, as I think it's a good
idea to display a warning for a potentially misspelled GUC prefix (but do
nothing else - certainly not remove it!). Will such a warning be seen?
Perhaps not, but that's a risk any warning message has to face. And
obviously there could be false positives if an extension decides to name
their GUCs something other than pg_available_extensions()->name but
hopefully that's a rare case (and shame on them if so.)

Cheers,
Greg

--
Crunchy Data - https://www.crunchydata.com
Enterprise Postgres Software Products & Tech Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2025-05-22 20:42:33 Re: Relstats after VACUUM FULL and CLUSTER
Previous Message Melanie Plageman 2025-05-22 20:19:41 Re: Assert("vacrel->eager_scan_remaining_successes > 0")