| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Assert("vacrel->eager_scan_remaining_successes > 0") |
| Date: | 2025-05-23 16:40:23 |
| Message-ID: | CAD21AoBO=bdPzCTC5FZ+hKfar45f0TzMCUS12VBpH5KvkaM2Sw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 22, 2025 at 1:19 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Thu, May 22, 2025 at 4:07 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Agreed. I've updated the patch. Does this address your comments?
>
> Yep. LGTM.
>
> I'd probably just remove the parenthetical remark about 20% from the
> commit message since that only applies to the success cap and
> referencing both the success and failure caps will make the sentence
> very long.
>
> from the commit message:
> pages (beyond 20% of the total number of all-visible but not
> all-frozen pages), this does not pose a practical concern as the
Agreed.
I'll remove that part and push early next week, barring any objections.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Florents Tselai | 2025-05-23 17:06:25 | Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part |
| Previous Message | Masahiko Sawada | 2025-05-23 16:35:50 | Re: Fix slot synchronization with two_phase decoding enabled |