| From: | Amul Sul <sulamul(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Robert Treat <rob(at)xzilla(dot)net>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: alter check constraint enforceability |
| Date: | 2025-12-15 11:49:00 |
| Message-ID: | CAAJ_b95QpTcE6WcbiNUy3Xzs3Bt7MFgofSgQLdzY+B-7cMVyeA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2025 at 1:25 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> On Mon, Dec 8, 2025 at 5:58 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>> [....]
>
> v5-0001:
> AlterConstrEnforceabilityRecurse renamed to AlterFKConstrEnforceabilityRecurse n
> ATExecAlterConstrEnforceability renamed to ATExecAlterFKConstrEnforceability.
> comments slightly adjusted, no other changes.
>
Looks good to me, thanks !
> v5-0002: alter check constraint enforceability
>
The patch also looks good, but I have a minor comment for the test --
you created the check_constraint_status view, which is not dropped, it
should be dropped at the end. Also, instead of a view, I think you
could use the \set psql-meta-command; for example, see the
init_range_parted or show_data tests in update.sql
Also, run pgindent on both patches.
Regards,
Amul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2025-12-15 11:58:40 | Re: Confused static assertion implementation |
| Previous Message | Dilip Kumar | 2025-12-15 11:41:06 | Re: Proposal: Conflict log history table for Logical Replication |