Re: alter check constraint enforceability

On Mon, Dec 15, 2025 at 7:49 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> > v5-0002: alter check constraint enforceability
> >
> The patch also looks good, but I have a minor comment for the test --
> you created the check_constraint_status view, which is not dropped, it
> should be dropped at the end. Also, instead of a view, I think you
> could use the \set psql-meta-command; for example, see the
> init_range_parted or show_data tests in update.sql
>
> Also, run pgindent on both patches.
>

i have tried using \set, but it seems to require the query within a single line.
since the view check_constraint_status definition is quite longer, \set would
make it less readable, so I choose to use view.

previously I use
+ newcon = (NewConstraint *) palloc0(sizeof(NewConstraint));
now use
+ newcon = palloc0_object(NewConstraint);

v6-0001, v6-0002 both indented properly via pgindent, also polished the commit
messages.

--
jian
https://www.enterprisedb.com/