Remove unused vacuum-truncate-auto injection point

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Remove unused vacuum-truncate-auto injection point
Date: 2026-08-07 22:00:43
Message-ID: CAA5RZ0vV=CWB87OyQTKxaAF1nmibhHNrumJb4tLh+pyBH2M_dw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

While looking at these injection points I noticed vacuum-truncate-auto
in vacuum_rel() can never fire:

```
#ifdef USE_INJECTION_POINTS
if (params.truncate == VACOPTVALUE_AUTO)
INJECTION_POINT("vacuum-truncate-auto", NULL);
else if (params.truncate == VACOPTVALUE_DISABLED)
INJECTION_POINT("vacuum-truncate-disabled", NULL);
else if (params.truncate == VACOPTVALUE_ENABLED)
INJECTION_POINT("vacuum-truncate-enabled", NULL);
#endif
```

truncate is a boolean and can never be VACOPTVALUE_AUTO

```
Assert(params->truncate != VACOPTVALUE_UNSPECIFIED &&
params->truncate != VACOPTVALUE_AUTO);
```

This looks like an oversight from 661643dedad, perhaps to mirror
index_cleanup?

```
if (params.index_cleanup == VACOPTVALUE_AUTO)
INJECTION_POINT("vacuum-index-cleanup-auto", NULL);
```

Small cleanup attached.

--
Sami Imseih
Amazon Web Services (AWS)

Attachment Content-Type Size
v1-0001-Remove-unused-vacuum-truncate-auto-injection-poin.patch application/octet-stream 3.5 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2026-08-07 22:02:21 Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS?
Previous Message Nathan Bossart 2026-08-07 21:36:20 Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS?