Re: Remove unused vacuum-truncate-auto injection point

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unused vacuum-truncate-auto injection point
Date: 2026-08-07 22:11:42
Message-ID: anZYHssvF7RAS4Ff@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 07, 2026 at 05:00:43PM -0500, Sami Imseih wrote:
> This looks like an oversight from 661643dedad, perhaps to mirror
> index_cleanup?
>
> ```
> if (params.index_cleanup == VACOPTVALUE_AUTO)
> INJECTION_POINT("vacuum-index-cleanup-auto", NULL);
> ```
>
> Small cleanup attached.

I am pretty sure that I have defined this one to be able to track more
easily an inconsistency if someone reworks this code, so as it becomes
possible to see if the value is set to "auto" when crossing this code
path, or at least consider if this is a good idea when doing an index
cleanup. Leaving things as they are now is not that bad, IMO. That's
just one opinion, I'm fine to be outvoted.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dhruv Aron 2026-08-07 22:14:05 Re: Restructured Shared Buffer Hash Table
Previous Message Nathan Bossart 2026-08-07 22:02:21 Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather than ROLERECURSE_PRIVS?