From af45958d0333a666ba6448602182d16fc88cad2f Mon Sep 17 00:00:00 2001 From: Sami Imseih Date: Fri, 7 Aug 2026 21:48:21 +0000 Subject: [PATCH v1 1/1] Remove unused vacuum-truncate-auto injection point vacuum truncate is a boolean and can never be VACOPTVALUE_AUTO, so the vacuum-truncate-auto injection point in vacuum_rel() can never run. This was an oversight in 661643dedad. Remove the dead injection point handling for this in vacuum.c and the tests in injection_points/sql/vacuum.sql. --- src/backend/commands/vacuum.c | 4 +--- .../modules/injection_points/expected/vacuum.out | 12 ------------ src/test/modules/injection_points/sql/vacuum.sql | 2 -- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c index 31f9824899c..57fd1ff720d 100644 --- a/src/backend/commands/vacuum.c +++ b/src/backend/commands/vacuum.c @@ -2267,9 +2267,7 @@ vacuum_rel(Oid relid, RangeVar *relation, VacuumParams params, } #ifdef USE_INJECTION_POINTS - if (params.truncate == VACOPTVALUE_AUTO) - INJECTION_POINT("vacuum-truncate-auto", NULL); - else if (params.truncate == VACOPTVALUE_DISABLED) + if (params.truncate == VACOPTVALUE_DISABLED) INJECTION_POINT("vacuum-truncate-disabled", NULL); else if (params.truncate == VACOPTVALUE_ENABLED) INJECTION_POINT("vacuum-truncate-enabled", NULL); diff --git a/src/test/modules/injection_points/expected/vacuum.out b/src/test/modules/injection_points/expected/vacuum.out index 58df59fa927..84a30ef2a33 100644 --- a/src/test/modules/injection_points/expected/vacuum.out +++ b/src/test/modules/injection_points/expected/vacuum.out @@ -24,12 +24,6 @@ SELECT injection_points_attach('vacuum-index-cleanup-enabled', 'notice'); (1 row) -SELECT injection_points_attach('vacuum-truncate-auto', 'notice'); - injection_points_attach -------------------------- - -(1 row) - SELECT injection_points_attach('vacuum-truncate-disabled', 'notice'); injection_points_attach ------------------------- @@ -101,12 +95,6 @@ SELECT injection_points_detach('vacuum-index-cleanup-enabled'); (1 row) -SELECT injection_points_detach('vacuum-truncate-auto'); - injection_points_detach -------------------------- - -(1 row) - SELECT injection_points_detach('vacuum-truncate-disabled'); injection_points_detach ------------------------- diff --git a/src/test/modules/injection_points/sql/vacuum.sql b/src/test/modules/injection_points/sql/vacuum.sql index 23760dd0f38..9bbe7c58486 100644 --- a/src/test/modules/injection_points/sql/vacuum.sql +++ b/src/test/modules/injection_points/sql/vacuum.sql @@ -6,7 +6,6 @@ SELECT injection_points_set_local(); SELECT injection_points_attach('vacuum-index-cleanup-auto', 'notice'); SELECT injection_points_attach('vacuum-index-cleanup-disabled', 'notice'); SELECT injection_points_attach('vacuum-index-cleanup-enabled', 'notice'); -SELECT injection_points_attach('vacuum-truncate-auto', 'notice'); SELECT injection_points_attach('vacuum-truncate-disabled', 'notice'); SELECT injection_points_attach('vacuum-truncate-enabled', 'notice'); @@ -41,7 +40,6 @@ DROP TABLE vac_tab_off_toast_on; SELECT injection_points_detach('vacuum-index-cleanup-auto'); SELECT injection_points_detach('vacuum-index-cleanup-disabled'); SELECT injection_points_detach('vacuum-index-cleanup-enabled'); -SELECT injection_points_detach('vacuum-truncate-auto'); SELECT injection_points_detach('vacuum-truncate-disabled'); SELECT injection_points_detach('vacuum-truncate-enabled'); DROP EXTENSION injection_points; -- 2.47.3