Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
Date: 2021-06-29 12:37:30
Message-ID: CAA4eK1Lz6kSK0Qp8xoy83KMRNrakt_XHCHcQc=AvfRzYJyx9Rg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Hi all,
>
> I realized that we use the magic number 10 instead of
> PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> function. It seems an oversight of the original commit. Attached patch
> fixes it.
>

LGTM. I'll take care of it tomorrow.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2021-06-29 13:10:30 Re: Speed up pg_checksums in cases where checksum already set
Previous Message vignesh C 2021-06-29 12:00:54 Re: [HACKERS] logical decoding of two-phase transactions