| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Date: | 2019-03-01 02:19:46 |
| Message-ID: | CAA4eK1LnM1zoFQ8Swuf+wTkWjxrN2mQ=1oZ+xSsiev434ipapA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Feb 28, 2019 at 9:59 AM John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> wrote:
>
> On Thu, Feb 28, 2019 at 10:25 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > Here's an updated patch based on comments by you. I will proceed with
> > this unless you have any more comments.
>
> Looks good to me. I would just adjust the grammar in the comment, from
> "This prevents us to use the map", to "This prevents us from using the
> map". Perhaps also a comma after "first".
>
Okay, pushed after making changes suggested by you.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2019-03-01 13:12:15 | Re: pgsql: Build src/port files as a library with -fPIC, and use that in li |
| Previous Message | Amit Kapila | 2019-03-01 02:12:32 | pgsql: Clear the local map when not used. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Glukhov | 2019-03-01 02:24:39 | Fix memleaks and error handling in jsonb_plpython |
| Previous Message | Martín Marqués | 2019-03-01 02:07:47 | Re: Remove Deprecated Exclusive Backup Mode |