| From: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <akapila(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| Date: | 2019-02-28 04:29:24 |
| Message-ID: | CACPNZCtKjx=apQ9keWzy4vM2v8=xGpkxx=K+pHEr9km=wsp0iw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Feb 28, 2019 at 10:25 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Here's an updated patch based on comments by you. I will proceed with
> this unless you have any more comments.
Looks good to me. I would just adjust the grammar in the comment, from
"This prevents us to use the map", to "This prevents us from using the
map". Perhaps also a comma after "first".
--
John Naylor https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-02-28 09:43:26 | pgsql: Update comment |
| Previous Message | Amit Kapila | 2019-02-28 03:25:12 | Re: pgsql: Avoid creation of the free space map for small heap relations, t |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-02-28 04:41:39 | Re: POC: converting Lists into arrays |
| Previous Message | Tom Lane | 2019-02-28 04:23:13 | Re: POC: converting Lists into arrays |