Re: Fix build of llvmjit_types.bc with meson

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix build of llvmjit_types.bc with meson
Date: 2025-11-17 10:58:26
Message-ID: CA+hUKGLrvRpxmv9LTbOVGqxxgGk+LSajtU1ogv90pG6Jyu8KzQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 17, 2025 at 11:09 PM Anthonin Bonnefoy
<anthonin(dot)bonnefoy(at)datadoghq(dot)com> wrote:
> The failure happens in the custom_target llvmjit_types.bc. The missing libintl.h header is available in /opt/homebrew/include/libintl.h which is provided as an extra_include_dirs. However, it won't be used by the custom_target which hardcodes the include path.

Right. I noticed that problem too. There are a couple of related
proposals over here:

https://www.postgresql.org/message-id/flat/CA%2BhUKGKispvxLyrBn3%3D3mp0BB1N%2BRBYR5eE2guCOksnwEoOcPQ%40mail.gmail.com

I think Andres and Tristan are probably right that extra_include_dirs
should go into cppflags. I would additionally also like to continue
my struggle to make it so that you don't even need extra_include_dirs
on a Mac or similar as long as pkg_config can find everything, but the
sticking point is libintl, which lacks a .pc file. I think my attempt
at that might not work for Brew though...

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-11-17 11:05:16 Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics
Previous Message Aleksander Alekseev 2025-11-17 10:56:54 Re: [PATCH] Refactor bytea_sortsupport(), take two