Re: Adjust the description of OutputPluginCallbacks in pg-doc

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Adjust the description of OutputPluginCallbacks in pg-doc
Date: 2023-01-20 04:40:29
Message-ID: CAA4eK1+qD306E+bD02OWtzXOG0zJU+B9W1b5vSOo55wwrO-LHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 20, 2023 at 8:03 AM wangw(dot)fnst(at)fujitsu(dot)com
<wangw(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Thurs, Jan 19, 2023 at 19:18 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > On Wed, Jan 11, 2023 at 4:20 PM wangw(dot)fnst(at)fujitsu(dot)com
> > <wangw(dot)fnst(at)fujitsu(dot)com> wrote:
> > >
> > > When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc
> > [1],
> > > I think in the summary section, only the callback message_cb is not described
> > > whether it is required or optional, and the description of callback
> > > stream_prepare_cb seems inaccurate.
> > >
> > > And after the summary section, I think only the callback stream_xxx_cb
> > section
> > > and the callback truncate_cb section are not described this tag (are they
> > > required or optional).
> > >
> > > I think we could improve these to be more reader friendly. So I tried to write
> > > a patch for these and attach it.
> > >
> > > Any thoughts?
> > >
> >
> > This looks mostly good to me. I have made minor adjustments in the
> > attached. Do those make sense to you?
>
> Thanks for your improvement.
> It makes sense to me.
>

Pushed.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2023-01-20 05:06:46 Re: Unicode grapheme clusters
Previous Message Michael Paquier 2023-01-20 04:35:15 Re: Generating code for query jumbling through gen_node_support.pl