From: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | RE: Adjust the description of OutputPluginCallbacks in pg-doc |
Date: | 2023-01-20 02:33:40 |
Message-ID: | OS3PR01MB627598CA2E5E0D5515B9DC919EC59@OS3PR01MB6275.jpnprd01.prod.outlook.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thurs, Jan 19, 2023 at 19:18 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Jan 11, 2023 at 4:20 PM wangw(dot)fnst(at)fujitsu(dot)com
> <wangw(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc
> [1],
> > I think in the summary section, only the callback message_cb is not described
> > whether it is required or optional, and the description of callback
> > stream_prepare_cb seems inaccurate.
> >
> > And after the summary section, I think only the callback stream_xxx_cb
> section
> > and the callback truncate_cb section are not described this tag (are they
> > required or optional).
> >
> > I think we could improve these to be more reader friendly. So I tried to write
> > a patch for these and attach it.
> >
> > Any thoughts?
> >
>
> This looks mostly good to me. I have made minor adjustments in the
> attached. Do those make sense to you?
Thanks for your improvement.
It makes sense to me.
Regards,
Wang Wei
From | Date | Subject | |
---|---|---|---|
Next Message | torikoshia | 2023-01-20 02:43:51 | Re: Record queryid when auto_explain.log_verbose is on |
Previous Message | Michael Paquier | 2023-01-20 02:26:05 | Re: [EXTERNAL] Re: [PATCH] Support using "all" for the db user in pg_ident.conf |