| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Snapbuild woes followup |
| Date: | 2021-01-29 08:34:47 |
| Message-ID: | CAA4eK1+6AWr18hDpQ1hbHmKdepWPPHTscY9mGEogznZ7mkWM1Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 26, 2021 at 2:18 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2021-01-25 12:00:08 -0800, Andres Freund wrote:
> > > > /*
> > > > * For backward compatibility reasons this has to be stored in the wrongly
> > > > * named field. Will be fixed in next major version.
> > > > */
> > > > return builder->was_running.was_xmax;
> > >
> > > We could fix that now... Andres, what did you have in mind for a proper
> > > name?
> >
> > next_phase_at seems like it'd do the trick?
>
The new proposed name sounds good to me.
> See attached patch...
LGTM.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiro Ikeda | 2021-01-29 08:49:00 | Re: About to add WAL write/fsync statistics to pg_stat_wal view |
| Previous Message | Marco | 2021-01-29 08:14:58 | [WIP] Reduce likelihood of fdw prepared statement collisions |