Re: Snapbuild woes followup

From: Andres Freund <andres(at)anarazel(dot)de>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: Snapbuild woes followup
Date: 2021-01-25 20:48:13
Message-ID: 20210125204813.iavrp2seuaaysmxa@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-01-25 12:00:08 -0800, Andres Freund wrote:
> > > /*
> > > * For backward compatibility reasons this has to be stored in the wrongly
> > > * named field. Will be fixed in next major version.
> > > */
> > > return builder->was_running.was_xmax;
> >
> > We could fix that now... Andres, what did you have in mind for a proper
> > name?
>
> next_phase_at seems like it'd do the trick?

See attached patch...

Attachment Content-Type Size
0001-Remove-backwards-compat-ugliness-in-snapbuild.c.patch text/x-diff 8.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2021-01-25 21:07:49 Re: [Patch] ALTER SYSTEM READ ONLY
Previous Message Alexey Kondratov 2021-01-25 20:11:38 Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly