From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, amul sul <sulamul(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, Bruce Momjian <bruce(at)momjian(dot)us>, amul sul <sul_amul(at)yahoo(dot)co(dot)in>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Bug in to_timestamp(). |
Date: | 2018-02-02 20:54:45 |
Message-ID: | CA+q6zcXAXS2srjDq5nNHReYo21MurOrt=c88yryUUixe5vPGag@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 1 February 2018 at 11:24, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>
> I fixed those messages, but in a different manner. I think that an
> unexpected character is unknown and neither space nor separator. And
> better to say that was expected space/separator character.
Sounds good, thanks.
> Attached fixed patch.
For some reason I can't apply it clean to the latest master:
(Stripping trailing CRs from patch; use --binary to disable.)
patching file doc/src/sgml/func.sgml
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/backend/utils/adt/formatting.c
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/test/regress/expected/horology.out
Hunk #1 FAILED at 2769.
Hunk #2 FAILED at 2789.
Hunk #3 succeeded at 2810 with fuzz 2.
Hunk #4 succeeded at 2981 with fuzz 2.
Hunk #5 succeeded at 3011 with fuzz 2.
Hunk #6 FAILED at 3029.
3 out of 6 hunks FAILED -- saving rejects to file
src/test/regress/expected/horology.out.rej
(Stripping trailing CRs from patch; use --binary to disable.)
patching file src/test/regress/sql/horology.sql
> On 2 February 2018 at 16:40, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
> I'm not quite sure whether it's relevant here, but I think some of the
> ctype.h functions have locale-dependent behavior. By implementing our
> own test we make sure that we don't accidentally inherit any such
> behavior.
Yes, you're right, `isalpha` is actually locale dependent function.
In some locales, there may be additional characters for which isalpha() is
true—letters which are neither uppercase nor lowercase.
So, if I understand the patch correctly, with `isalpha` the function
`is_separator_char` will return false for some locale-specific characters, and
without - those characters will be treated as separators. Is it desire
behavior?
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-02-02 20:56:56 | Re: ERROR: too many dynamic shared memory segments |
Previous Message | Robert Haas | 2018-02-02 20:49:21 | Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation) |