| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Cc: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, amul sul <sulamul(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, Bruce Momjian <bruce(at)momjian(dot)us>, amul sul <sul_amul(at)yahoo(dot)co(dot)in>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Bug in to_timestamp(). |
| Date: | 2018-02-02 15:40:03 |
| Message-ID: | CA+TgmoY2KAFz9H=kK0rh0ZYqVXXTOHACLbCHJV-eSwcNNn03Rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 31, 2018 at 11:53 AM, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> Why not write `is_separator_char` using `isprint`, `isalpha`, `isdigit` from
> ctype.h? Something like:
>
> return isprint(*str) && !isalpha(*str) && !isdigit(*str)
>
> From what I see in the source code they do exactly the same and tests are
> successfully passing with this change.
I'm not quite sure whether it's relevant here, but I think some of the
ctype.h functions have locale-dependent behavior. By implementing our
own test we make sure that we don't accidentally inherit any such
behavior.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2018-02-02 16:11:44 | Re: Wait for parallel workers to attach |
| Previous Message | Robert Haas | 2018-02-02 15:37:45 | Re: Changing WAL Header to reduce contention during ReserveXLogInsertLocation() |