| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Suppressing useless wakeups in walreceiver |
| Date: | 2022-11-08 07:46:26 |
| Message-ID: | CA+hUKGLSsr-KbgaEpGwsKBOa=M5oh9VtrNgRSvX-qohuYptQJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 8, 2022 at 3:20 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sun, Nov 6, 2022 at 12:01 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> > Here is a new version of the patch that addresses this feedback.
>
> This looks pretty good to me. Thanks for picking it up! I can live
> with the change to use a global variable; it seems we couldn't quite
> decide what the scope was for moving stuff into a struct (ie various
> pre-existing stuff representing the walreceiver's state), but I'm OK
> with considering that as a pure refactoring project for a separate
> thread. That array should be "static", though.
And with that change and a pgindent, pushed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-11-08 07:49:27 | Re: Add index scan progress to pg_stat_progress_vacuum |
| Previous Message | Bharath Rupireddy | 2022-11-08 07:17:23 | Re: Reviving lost replication slots |