| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Suppressing useless wakeups in walreceiver |
| Date: | 2022-11-08 21:06:39 |
| Message-ID: | 20221108210639.GA636909@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 08, 2022 at 08:46:26PM +1300, Thomas Munro wrote:
> On Tue, Nov 8, 2022 at 3:20 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> This looks pretty good to me. Thanks for picking it up! I can live
>> with the change to use a global variable; it seems we couldn't quite
>> decide what the scope was for moving stuff into a struct (ie various
>> pre-existing stuff representing the walreceiver's state), but I'm OK
>> with considering that as a pure refactoring project for a separate
>> thread. That array should be "static", though.
>
> And with that change and a pgindent, pushed.
Thanks!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-11-08 21:08:26 | Re: Suppressing useless wakeups in walreceiver |
| Previous Message | Tom Lane | 2022-11-08 20:40:43 | Re: Non-emergency patch for bug #17679 |