| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Suppressing useless wakeups in walreceiver |
| Date: | 2022-11-08 02:20:22 |
| Message-ID: | CA+hUKG+WyW=yumSEnNAGtgKUzf=MpY8NeyqqfDHzo6yAvtj0DA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 6, 2022 at 12:01 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Here is a new version of the patch that addresses this feedback.
This looks pretty good to me. Thanks for picking it up! I can live
with the change to use a global variable; it seems we couldn't quite
decide what the scope was for moving stuff into a struct (ie various
pre-existing stuff representing the walreceiver's state), but I'm OK
with considering that as a pure refactoring project for a separate
thread. That array should be "static", though.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-11-08 02:25:45 | Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment |
| Previous Message | John Naylor | 2022-11-08 02:17:46 | Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment |