| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EINTR in ftruncate() |
| Date: | 2022-07-15 04:19:10 |
| Message-ID: | CA+hUKGKBWH5z04dDWXfofaSCxHBNteDqrOVu8GJQayUybrp1hA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 15, 2022 at 9:34 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> (Someday we oughta go ahead and make our Windows signal API look more
> like POSIX, as I suggested back in 2015. I'm still not taking
> point on that, though.)
For the sigprocmask() part, here's a patch that passes CI. Only the
SIG_SETMASK case is actually exercised by our current code, though.
One weird thing about our PG_SETMASK() macro is that you couldn't have
used its return value portably: on Windows we were returning the old
mask (like sigsetmask(), which has no way to report errors), and on
Unix we were returning 0/-1 (from setprocmask(), ie the error we never
checked).
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Emulate-sigprocmask-not-sigsetmask-on-Windows.patch | text/x-patch | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | kuroda.hayato@fujitsu.com | 2022-07-15 04:56:45 | RE: Support load balancing in libpq |
| Previous Message | Michael Paquier | 2022-07-15 03:44:16 | Re: Allowing REINDEX to have an optional name |