Re: Tab completion regression test failed on illumos

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Japin Li <japinli(at)hotmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Tab completion regression test failed on illumos
Date: 2023-11-03 02:03:19
Message-ID: CA+hUKGKA8ZTZzudCwjRGWXrtMmTfoBDSxO-OwG2_62n+JvT4-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Fri, Nov 3, 2023 at 3:42 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
> > this by using pseudo-tty on Illumos.
>
> I don't know but my guess is that this has to do with termios defaults
> being different. From a quick look at 'man termios', perhaps TABDLY
> is set to expand tabs to spaces? Can you fix it by tweaking the flags
> in src/common/sprompt.c?

Argh, sorry that's completely the wrong end. I suppose that sort of
thing would have to happen in IPC::Run. I wonder what would happen if
IPC::Run called ->set_raw() on the IO::Pty object it constructs, or
failing that, if IO::Stty can be used to mess with the relevant
settings.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-11-03 02:11:20 Re: A recent message added to pg_upgade
Previous Message David Rowley 2023-11-03 01:30:07 Re: Possible typo in nodeAgg.c