From: | Japin Li <japinli(at)hotmail(dot)com> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Tab completion regression test failed on illumos |
Date: | 2023-11-03 02:14:35 |
Message-ID: | MEYP282MB166968B5C8DAAABF02292D19B6A5A@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, 03 Nov 2023 at 10:03, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>> On Fri, Nov 3, 2023 at 3:42 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
>> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
>> > this by using pseudo-tty on Illumos.
>>
>> I don't know but my guess is that this has to do with termios defaults
>> being different. From a quick look at 'man termios', perhaps TABDLY
>> is set to expand tabs to spaces? Can you fix it by tweaking the flags
>> in src/common/sprompt.c?
>
> Argh, sorry that's completely the wrong end. I suppose that sort of
> thing would have to happen in IPC::Run. I wonder what would happen if
> IPC::Run called ->set_raw() on the IO::Pty object it constructs, or
> failing that, if IO::Stty can be used to mess with the relevant
> settings.
Thanks for your explantation, the termios.c_oflag on Illumos enables TABDLY
by default.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-11-03 02:32:28 | Re: Moving forward with TDE [PATCH v3] |
Previous Message | Amit Kapila | 2023-11-03 02:11:20 | Re: A recent message added to pg_upgade |