From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: What's with all the fflush(stderr) calls in pg_standby.c? |
Date: | 2017-09-25 00:45:09 |
Message-ID: | CA+TgmobuTx+Ck9orX_Yen=Z764Zmsv7cSCVi6OMoMR7myoQLGA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Sep 24, 2017 at 11:51 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> This looks like cargo-cult programming to me. stderr is almost
> always line-buffered, making these fflush'es pointless. If it's
> not line-buffered, that's probably because it's going to a
> noninteractive destination for which this wouldn't matter.
> Moreover, none of our other programs do this.
On a related note, the idea of removing pg_standby altogether has been
proposed a few times. Apparently there are a few things that it still
does better than standby_mode, but nobody seems in a hurry to do
anything about that. Still, I'd be against spending a lot of time
trying to improve a tool that has mostly outlived its usefulness - we
ought to be trying to enhance the in-core facilities instead.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Wagner | 2017-09-25 00:52:43 | Re: Fix number skipping in to_number |
Previous Message | Andrew Dunstan | 2017-09-25 00:42:25 | Re: BUG #14825: enum type: unsafe use? |