What's with all the fflush(stderr) calls in pg_standby.c?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: What's with all the fflush(stderr) calls in pg_standby.c?
Date: 2017-09-24 15:51:25
Message-ID: 7232.1506268285@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This looks like cargo-cult programming to me. stderr is almost
always line-buffered, making these fflush'es pointless. If it's
not line-buffered, that's probably because it's going to a
noninteractive destination for which this wouldn't matter.
Moreover, none of our other programs do this.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2017-09-24 15:58:19 logical replication and statistics
Previous Message Simon Riggs 2017-09-24 14:45:37 Re: Built-in plugin for logical decoding output