| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Subject: | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| Date: | 2017-01-13 20:09:57 |
| Message-ID: | 20170113200957.7rdnmtiuatxd3ix6@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas wrote:
> On Fri, Jan 13, 2017 at 2:31 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> > On Fri, Jan 13, 2017 at 2:18 PM, Alvaro Herrera
> > <alvherre(at)2ndquadrant(dot)com> wrote:
> >> Hmm, we were discussing this stuff a few days ago, see
> >> https://www.postgresql.org/message-id/20170109182800.qrkae62kmur3gfeg@alvherre.pgsql
> >> and commit 3957b58b8885441c8d03bc1cfc00e47cf8cd7975. Part of this code
> >> duplicates that ...
> >
> > Is that bad?
>
> If you are expressing a concern about who wrote this code, I took
> Amit's word for it that he did.
I'm just saying that the problem at hand is already solved for a related
feature, so ISTM this new code should use the recently added routine
rather than doing the same thing in a different way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-13 21:10:02 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| Previous Message | Robert Haas | 2017-01-13 19:35:25 | Re: [COMMITTERS] pgsql: Fix a bug in how we generate partition constraints. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-01-13 20:32:08 | Re: patch: function xmltable |
| Previous Message | Serge Rielau | 2017-01-13 19:38:49 | Re: Packages: Again |