| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: making EXPLAIN extensible |
| Date: | 2025-05-03 18:44:43 |
| Message-ID: | 25642340-0f04-4a19-a332-e6567dd436f6@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28/3/2025 14:09, Robert Haas wrote:
> On Thu, Mar 27, 2025 at 5:34 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
>> I’m afraid to sound like a bore, but I think pg_overexplain should
>> include a call into the hook call chain (see attachment). Who knows,
>> maybe this extension will be used someday in production?
>
> Oh, bother, that was a silly mistake on my part. Thanks, committed.
I have one additional proposal.
I currently use this interface and have noticed that the parameter
`option_name` in the RegisterExtensionExplainOption routine is
case-sensitive. Since SQL treats our extended options as
case-insensitive, it would be beneficial to either add a comment
clarifying this behavior or forcedly convert incoming text constant to
lowercase.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2025-05-03 19:30:52 | Re: pg_dump to support "on conflict do update" |
| Previous Message | Tanin Na Nakorn | 2025-05-03 18:30:44 | pg_dump to support "on conflict do update" |