From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Peter Geoghegan <pg(at)heroku(dot)com> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minor clarifying changes to abbreviated key abort code comments |
Date: | 2015-11-03 19:15:51 |
Message-ID: | CA+TgmobHneTRAnKHQtJ1MHvuc7ruz6v5da-JhFwP-pHdOxp0AQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Nov 3, 2015 at 12:36 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> On Tue, Nov 3, 2015 at 5:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> This comment doesn't make sense to me:
>>
>> + * (TSS_BUILDRUNS state prevents control reaching here in any
>> + * case).
>>
>> Unless I'm missing something, that's not actually true.
>
> It is true. consider_abort_common() only actually considers aborting
> when state is TSS_INITIAL (we're still doing an internal sort). The
> only other pertinent state here is TSS_BUILDRUNS. The point is that
> TSS_BUILDRUNS is a generic "point of no return" past which
> abbreviation cannot be aborted. That is a little arbitrary.
OK, I see. Fixing comments in the back-branches is not always a
productive use of time, and in general I might like it if you pushed
for such things less frequently. But I've done it anyway in this
instance.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2015-11-03 19:19:28 | Re: Minor clarifying changes to abbreviated key abort code comments |
Previous Message | Jeff Janes | 2015-11-03 18:58:32 | Bitmap index scans use of filters on available columns |