Re: Minor clarifying changes to abbreviated key abort code comments

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor clarifying changes to abbreviated key abort code comments
Date: 2015-11-03 17:36:37
Message-ID: CAM3SWZS_mUTNnmBgaD5dXtt3VGLhWvPx1Q66N1EWWtP88_6w8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 3, 2015 at 5:47 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> This comment doesn't make sense to me:
>
> + * (TSS_BUILDRUNS state prevents control reaching here in any
> + * case).
>
> Unless I'm missing something, that's not actually true.

It is true. consider_abort_common() only actually considers aborting
when state is TSS_INITIAL (we're still doing an internal sort). The
only other pertinent state here is TSS_BUILDRUNS. The point is that
TSS_BUILDRUNS is a generic "point of no return" past which
abbreviation cannot be aborted. That is a little arbitrary.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-11-03 17:38:22 Re: September 2015 Commitfest
Previous Message Robert Haas 2015-11-03 17:31:59 Re: fortnight interval support