Re: Minor clarifying changes to abbreviated key abort code comments

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor clarifying changes to abbreviated key abort code comments
Date: 2015-11-03 19:19:28
Message-ID: CAM3SWZTF=eCT8==5E-_TWeivfKY-bTJwcmDfy432CPXDNVnPmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 3, 2015 at 11:15 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> OK, I see. Fixing comments in the back-branches is not always a
> productive use of time, and in general I might like it if you pushed
> for such things less frequently. But I've done it anyway in this
> instance.

I guess I favor doing it where the comment is actually wrong, which
does apply here -- we don't *rely* on anything. We could very well
abort when state is TSS_BUILDRUNS, but we elect not too, since
TSS_BUILDRUNS is taken to mean that it's too late for aborting to be
worth it.

Thanks
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-11-03 19:24:18 Re: Minor clarifying changes to abbreviated key abort code comments
Previous Message Robert Haas 2015-11-03 19:15:51 Re: Minor clarifying changes to abbreviated key abort code comments