| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Bitmap scans a bit broken |
| Date: | 2017-03-16 15:12:36 |
| Message-ID: | CA+TgmoajNzDSVARXhOCLJJLg+otHOd-7XAa_LtmEMr9aBMhXzw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2017 at 10:56 AM, Emre Hasegeli <emre(at)hasegeli(dot)com> wrote:
>> Hopefully, this time I got it correct. Since I am unable to reproduce
>> the issue so I will again need your help in verifying the fix.
>
> It is not crashing with the new patch. Thank you.
Thanks for confirming. Some review comments on v2:
+ if (istate->pagetable)
Please compare explicitly to InvalidDsaPointer.
+ if (iterator->ptbase)
+ ptbase = iterator->ptbase->ptentry;
+ if (iterator->ptpages)
+ idxpages = iterator->ptpages->index;
+ if (iterator->ptchunks)
+ idxchunks = iterator->ptchunks->index;
Similarly.
Dilip, please also provide a proposed commit message describing what
this is fixing. Is it just the TBM_EMPTY case, or is there anything
else?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-16 15:15:16 | Re: WIP: Faster Expression Processing v4 |
| Previous Message | David Steele | 2017-03-16 15:12:17 | Re: Crash on promotion when recovery.conf is renamed |