| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Emre Hasegeli <emre(at)hasegeli(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Parallel Bitmap scans a bit broken |
| Date: | 2017-03-16 17:50:15 |
| Message-ID: | CAFiTN-sqFOrxNJgCc_KOKam2nqbza9PVOh2do566MxfBWkeiHw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 16, 2017 at 8:42 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Thanks for confirming. Some review comments on v2:
>
> + if (istate->pagetable)
fixed
>
> Please compare explicitly to InvalidDsaPointer.
>
> + if (iterator->ptbase)
> + ptbase = iterator->ptbase->ptentry;
> + if (iterator->ptpages)
> + idxpages = iterator->ptpages->index;
> + if (iterator->ptchunks)
> + idxchunks = iterator->ptchunks->index;
>
> Similarly.
fixed
Also fixed at
+ if (ptbase)
+ pg_atomic_init_u32(&ptbase->refcount, 0);
>
> Dilip, please also provide a proposed commit message describing what
> this is fixing. Is it just the TBM_EMPTY case, or is there anything
> else?
Okay, I have added the commit message in the patch.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| fix_tbm_empty_v3.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2017-03-16 17:50:42 | Re: Parallel Bitmap scans a bit broken |
| Previous Message | David Steele | 2017-03-16 17:48:54 | Re: PinBuffer() no longer makes use of strategy |