Re: pg_basebackup ignores the existing data directory permissions

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_basebackup ignores the existing data directory permissions
Date: 2019-03-18 13:47:20
Message-ID: CA+TgmoaVo09Se=xYwBjhxpzuMK=SAG4v9QJC5YWKHcBZqUsfwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 18, 2019 at 4:16 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote:
> > On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> >> I definitely think that we should add an option to allow the user to
> >> tell us explicitly what they want here, even if we also go based on what
> >> the created directory has (and in that case, we should make everything,
> >> including the base directory, follow what the user asked for).
> >
> > +1 for having an option to override whatever the default is.
>
> Based on the feedback gathered, having a separate option to enforce
> the default and not touching the behavior implemented until now,
> sounds fine to me.

That's not what I'm proposing. I think the behavior implemented until
now is not best, because the files within the directory should inherit
the directory's permissions, not the remote side's permissions.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-03-18 14:02:15 Re: partitioned tables referenced by FKs
Previous Message Hugh Ranalli 2019-03-18 13:06:09 Re: Unaccent extension python script Issue in Windows