Re: pg_basebackup ignores the existing data directory permissions

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_basebackup ignores the existing data directory permissions
Date: 2019-03-18 08:16:01
Message-ID: 20190318081601.GI1885@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 18, 2019 at 08:32:44AM +0100, Magnus Hagander wrote:
> On Mon, Mar 18, 2019 at 7:08 AM Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>> I definitely think that we should add an option to allow the user to
>> tell us explicitly what they want here, even if we also go based on what
>> the created directory has (and in that case, we should make everything,
>> including the base directory, follow what the user asked for).
>
> +1 for having an option to override whatever the default is.

Based on the feedback gathered, having a separate option to enforce
the default and not touching the behavior implemented until now,
sounds fine to me.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2019-03-18 08:18:21 Re: partitioned tables referenced by FKs
Previous Message Michael Paquier 2019-03-18 08:13:01 Re: Offline enabling/disabling of data checksums