Re: pgsql: Add suport for server-side LZ4 base backup compression.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: 2022-02-13 16:13:51
Message-ID: CA+TgmoaUpPBfKOrn_4LZOzo8Tohaj-U9sURAaPY8Q76nn62-HQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Feb 12, 2022 at 11:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Eh? copperhead for one is failing for exactly this reason:
>
> Bailout called. Further testing stopped: failed to execute command "lz4 -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4": No such file or directory

Well, that's because I didn't realize that LZ4 might be set to
something that doesn't work at all. So Michael's thing worked, but
because it (in my view) fixed the problem in a more surprising place
than I would have preferred, I made a commit later that turned out to
break the buildfarm. So you can blame either one of us that you like.

Thanks, Michael, for preparing a patch.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2022-02-13 17:08:26 Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding
Previous Message Alvaro Herrera 2022-02-13 15:26:37 Re: pgsql: Fix skip-empty-xacts with sequences in test_decoding

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-02-13 16:26:07 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Joseph Koshakow 2022-02-13 14:35:47 Re: Fix overflow in DecodeInterval