| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor comment improvement to create_foreignscan_plan |
| Date: | 2015-11-17 17:57:55 |
| Message-ID: | CA+TgmoaC00we+cWDd1BsNHyrYwGA45USJrn0rmFgT7yzBWekRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Oops, I've found another one. I think we should update a comment in
> postgresGetForeignPlan, too; add remote filtering expressions to the list of
> information needed to create a ForeignScan node.
Instead of saying "remote/local", how about saying "remote and local"
or just leaving it out altogether as in the attached?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| pgfdw-comment-fix.patch | text/x-diff | 734 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Shaplov | 2015-11-17 18:10:33 | Re: pageinspect patch, for showing tuple data |
| Previous Message | Robert Haas | 2015-11-17 17:55:19 | Re: Parallel Seq Scan |