| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minor comment improvement to create_foreignscan_plan |
| Date: | 2015-11-16 02:25:36 |
| Message-ID: | 56493EA0.2000101@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2015/11/12 19:02, Etsuro Fujita wrote:
> On 2015/11/10 3:53, Robert Haas wrote:
>> On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita
>> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>> Here is a small patch to update an comment in create_foreignscan_plan;
>>> add fdw_recheck_quals to the list of expressions that need the
>>> replace_nestloop_params processing. I should have updated the comment
>>> when I proposed the patch for the fdw_recheck_quals.
>> OK, not a big deal, but thanks. Committed.
> Thanks!
Oops, I've found another one. I think we should update a comment in
postgresGetForeignPlan, too; add remote filtering expressions to the
list of information needed to create a ForeignScan node.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| postgresGetForeignPlan-comment.patch | text/x-diff | 715 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-11-16 02:27:33 | Re: Proposing COPY .. WITH PERMISSIVE |
| Previous Message | Craig Ringer | 2015-11-16 02:10:42 | Re: pglogical_output - a general purpose logical decoding output plugin |