Re: Minor comment improvement to create_foreignscan_plan

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor comment improvement to create_foreignscan_plan
Date: 2015-11-18 02:29:04
Message-ID: 564BE270.6060809@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015/11/18 2:57, Robert Haas wrote:
> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
> <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> Oops, I've found another one. I think we should update a comment in
>> postgresGetForeignPlan, too; add remote filtering expressions to the list of
>> information needed to create a ForeignScan node.

> Instead of saying "remote/local", how about saying "remote and local"
> or just leaving it out altogether as in the attached?

+1 for your patch.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2015-11-18 02:30:27 Re: Foreign join pushdown vs EvalPlanQual
Previous Message Kouhei Kaigai 2015-11-18 01:47:23 Re: Foreign join pushdown vs EvalPlanQual