Re: [HACKERS] BUG #12989: pg_size_pretty with negative values

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "Adrian(dot)Vondendriesch" <Adrian(dot)Vondendriesch(at)credativ(dot)de>
Cc: Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Christian Almeida <cbalmeida(at)gmail(dot)com>
Subject: Re: [HACKERS] BUG #12989: pg_size_pretty with negative values
Date: 2015-11-06 16:06:17
Message-ID: CA+Tgmoa8XC=nqDBPMvWxGyfH1r1VpiMj98JcNYYPc55xdjotiA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, Nov 5, 2015 at 4:19 PM, Adrian.Vondendriesch
<Adrian(dot)Vondendriesch(at)credativ(dot)de> wrote:
> New patch attached and rebased on HEAD
> (8c75ad436f75fc629b61f601ba884c8f9313c9af).

I've committed this with some modifications:

- I changed the comment for the half_rounded() macros because the one
you had just restated the code.
- I tightened up the coding in numeric_half_rounded() very slightly.
- You didn't, as far as I can see, modify the regression test schedule
to execute the files you added. I consolidated them into one file,
added it to the schedule, and tightened up the SQL a bit.

Thanks for the patch, and please let me know if I muffed anything.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Kevin Grittner 2015-11-06 16:31:59 Re: BUG #13757: Able to write to postgres even when the main process has been killed
Previous Message Haribabu Kommi 2015-11-06 09:34:05 Re: Memory leak with PL/Python trigger

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-11-06 16:19:00 Re: patch for geqo tweaks
Previous Message Alvaro Herrera 2015-11-06 15:38:07 Re: Patch: Implement failover on libpq connect level.