Re: patch for geqo tweaks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Wagner <nw+pg(at)hydaspes(dot)if(dot)org>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for geqo tweaks
Date: 2015-11-06 16:19:00
Message-ID: 19686.1446826740@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Wagner <nw+pg(at)hydaspes(dot)if(dot)org> writes:
> I see you committed a modified version of my patch in commit
> 59464bd6f928ad0da30502cbe9b54baec9ca2c69.

> You changed the tour[0] to be hardcoded to 1, but it should be any of
> the possible gene numbers from 0 to remainder.

How so? The intent is to replace the first iteration of the Fisher-Yates
loop, not the old loop. That iteration will certainly end by assigning
1 to tour[0], because it must choose j = i = 0.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-11-06 16:32:52 Re: Getting sorted data from foreign server for merge join
Previous Message Robert Haas 2015-11-06 16:06:17 Re: [HACKERS] BUG #12989: pg_size_pretty with negative values