Re: [PATCH] Change "checkpoint starting" message to use "wal"

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Change "checkpoint starting" message to use "wal"
Date: 2018-11-29 21:28:27
Message-ID: CA+Tgmoa8EFV0BnOrvHMJBLTsOUeVcFK6ftbJHdea9iRdJFM1NQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 29, 2018 at 4:10 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Nov 29, 2018 at 10:04:12AM +0100, Christoph Berg wrote:
> > There's hundreds of other internal uses of xlog that were not touched
> > either, only the user-facing parts were changed.
>
> I have heard of them ;)
> Just wondering if this one is worth renaming as the variable is
> isolated. It is not a big deal to do nothing though.

Well, if we rename the user-visible part but not the internal part,
then they don't match, which is odd.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-11-29 21:34:13 Re: [HACKERS] GnuTLS support
Previous Message Robert Haas 2018-11-29 21:27:20 Re: [HACKERS] GnuTLS support